Opened 2 years ago

Closed 2 years ago

#34102 closed Bug (fixed)

Admin list view `word-break: break-word;`

Reported by: Collin Anderson Owned by: Collin Anderson
Component: contrib.admin Version: dev
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Hi All,

15682cb0034242fcdfe333cf399d62ab70c3a978 / ​https://github.com/django/django/pull/16164 (Fixed wrapping of long model names in the admin, Oct 10, 2022) put word-break: break-word; on all td, th table cells in the entire admin.

That kinda messes up admin list view when there's a lot of columns, where it's now breaking data mid-word or mid-email, etc. It might "break" other things too. I'd suggest sticking to the browser default word-break for most tables, and maybe limit word-break: break-word; to just the index page.

Thanks,
Collin

Change History (4)

comment:1 by Mariusz Felisiak, 2 years ago

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

Thanks for the report! Visual regression in 15682cb0034242fcdfe333cf399d62ab70c3a978.

I'd suggest sticking to the browser default word-break for most tables, and maybe limit word-break: break-word; to just the index page.

Sounds good. Would you like to prepare a patch?

comment:2 by Collin Anderson, 2 years ago

Has patch: set

Ok here's a patch: ​https://github.com/django/django/pull/16190

comment:3 by Mariusz Felisiak, 2 years ago

Owner: changed from nobody to Collin Anderson
Status: new → assigned

comment:4 by GitHub <noreply@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In 7847004:

Fixed #34102 -- Limited wrapping long names to admin dashboard.

Regression in 15682cb0034242fcdfe333cf399d62ab70c3a978.

Note: See TracTickets for help on using tickets.
Back to Top