Opened 2 years ago
Closed 2 years ago
#34094 closed Bug (fixed)
RTL alignment is off in admin header area
Reported by: | Thibaud Colas | Owned by: | Francesco Panico |
---|---|---|---|
Component: | contrib.admin | Version: | 4.1 |
Severity: | Normal | Keywords: | rtl |
Cc: | Sarah Abderemane, Shai Berger, Amine Zyad, Francesco Panico | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | yes |
Description
There are two RTL spacing / alignment issues in the admin header area which are unrelated but should be straightforward to address at the same time:
- The h1 "branding" has a left margin, which should be switched to the right for RTL languages
- The theme switcher’s
.theme-toggle
’smargin-left
should also switch to the right.
Both margins can be switched to use margin-inline-start
, so the correct spacing is used in RTL languages. No need to add to the separate RTL-only stylesheet.
Attachments (2)
Change History (10)
by , 2 years ago
Attachment: | Screenshot 2022-10-13 at 17.51.52.png added |
---|
comment:1 by , 2 years ago
Cc: | added |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 2 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:5 by , 2 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:6 by , 2 years ago
Is the margin on div#branding h1
a right margin, that should be turned into a left margin for RTL languages?
by , 2 years ago
Attachment: | Schermata 2022-10-30 alle 02.12.03.png added |
---|
comment:8 by , 2 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed in c01e76c95caa1bd2995f1b6c186cbe8726c92ef9.
Note:
See TracTickets
for help on using tickets.
Thanks for the report!