Opened 2 years ago

Last modified 2 years ago

#34093 closed Bug

Admin theme switcher icon should resize according to browser font size — at Version 1

Reported by: Thibaud Colas Owned by: nobody
Component: contrib.admin Version: dev
Severity: Release blocker Keywords: accessibility, ux, font size, dark mode
Cc: Sarah Abderemane Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description (last modified by Thibaud Colas)

The new admin theme switcher’s icon is a fixed 16x16px, regardless of the browser’s configured font size. It would be better for users requiring larger text if icons resized as well.

This seems to be due to the icons’ SVG symbols having hard-coded width and height attributes, which prevents resizing with CSS. I believe the width and height should either be removed, or set on the inline SVG (which can be a bit tedious).

Screenshot: https://code.djangoproject.com/raw-attachment/ticket/34093/Screenshot%202022-10-13%20at%2017.44.39.png

Relevant code: https://github.com/django/django/blob/da8fa764134980ee1079f790cda6616f32cf9c44/django/contrib/admin/templates/admin/base.html#L118-L122

Change History (2)

by Thibaud Colas, 2 years ago

comment:1 by Thibaud Colas, 2 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top