Opened 2 years ago
Closed 2 years ago
#34093 closed Bug (fixed)
Admin theme switcher icon should resize according to browser font size
Reported by: | Thibaud Colas | Owned by: | Colm O'Connor |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Release blocker | Keywords: | accessibility, ux, font size, dark mode |
Cc: | Sarah Abderemane | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | yes |
Description (last modified by )
The new admin theme switcher’s icon is a fixed 16x16px, regardless of the browser’s configured font size. It would be better for users requiring larger text if icons resized as well.
This seems to be due to the icons’ SVG symbols having hard-coded width
and height
attributes, which prevents resizing with CSS. I believe the width
and height
should either be removed, or set on the inline SVG (which can be a bit tedious).
Screenshot: https://code.djangoproject.com/raw-attachment/ticket/34093/Screenshot%202022-10-13%20at%2017.44.39.png
Attachments (1)
Change History (6)
by , 2 years ago
Attachment: | Screenshot 2022-10-13 at 17.44.39.png added |
---|
comment:1 by , 2 years ago
Description: | modified (diff) |
---|
comment:2 by , 2 years ago
Cc: | added |
---|---|
Severity: | Normal → Release blocker |
Triage Stage: | Unreviewed → Accepted |
comment:3 by , 2 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Visual regression in bc7aa2a5e91cf65fc7510edaf1776528c7ad07b4.