Opened 2 years ago

Closed 21 months ago

Last modified 4 months ago

#34045 closed Bug (fixed)

Admin changelist checkboxes do not have labels

Reported by: Tom Carrick Owned by: Durval Carvalho
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Sarah Abderemane Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Tom Carrick)

This is failing WCAG level A so is quite fundamental. Screen reader users currently have no way to know what these checkboxes are for. We should add some kind of screenreader friendly label to make it clear you're selecting this row for running an action.

I'm not quite sure on the text. As the checkbox appears before the text describing the row I'm not sure if it'd need any extra info on the label - I suppose if we just added the label we'd be asking the user to select something that they don't yet know what it is?

Attachments (1)

Screenshot 2022-09-30 at 12.37.20 AM.png​ (56.8 KB ) - added by Neeraj Kumar 2 years ago.
Selection checkbox

Download all attachments as: .zip

Change History (14)

comment:1 by Mariusz Felisiak, 2 years ago

Triage Stage: Unreviewed → Accepted

I guess we need aria-labels. Tentatively accepted.

I'd be grateful for any description, by the way 😉.

comment:2 by Tom Carrick, 2 years ago

Description: modified (diff)

by Neeraj Kumar, 2 years ago

Attachment: Screenshot 2022-09-30 at 12.37.20 AM.png​ added

Selection checkbox

comment:3 by Neeraj Kumar, 2 years ago

Owner: changed from nobody to Neeraj Kumar
Status: new → assigned
UI/UX: set

Added a screenshot, we can use "Select all" text for checkbox label

comment:4 by Durval Carvalho, 21 months ago

Owner: changed from Neeraj Kumar to Durval Carvalho

comment:5 by Durval Carvalho, 21 months ago

Hey, guys!

I was working on this ticket and Mariusz Felisiak wrote that each line should have a defined aria label [¹]. But I'm not sure which text I should use. Maybe the str(instance)? What do you think?

[¹] ​https://github.com/django/django/pull/16515#issuecomment-1410872283

comment:6 by Sarah Abderemane, 21 months ago

Cc: Sarah Abderemane added

comment:7 by Mariusz Felisiak, 21 months ago

Has patch: set

​PR

comment:8 by Mariusz Felisiak, 21 months ago

Patch needs improvement: set

comment:9 by Mariusz Felisiak, 21 months ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:10 by Mariusz Felisiak <felisiak.mariusz@…>, 21 months ago

Resolution: → fixed
Status: assigned → closed

In 85366fb:

Fixed #34045 -- Improved accessibility of selecting items in admin changelist.

This adds "aria-label".

comment:11 by Sarah Boyce <42296566+sarahboyce@…>, 4 months ago

In 182f262b:

Fixed #35606, Refs #34045 -- Fixed rendering of ModelAdmin.action_checkbox for models with a html method.

Thank you Claude Paroz for the report.

Regression in 85366fbca723c9b37d0ac9db1d44e3f1cb188db2.

comment:12 by Sarah Boyce <42296566+sarahboyce@…>, 4 months ago

In 5eef80b:

[5.1.x] Fixed #35606, Refs #34045 -- Fixed rendering of ModelAdmin.action_checkbox for models with a html method.

Thank you Claude Paroz for the report.

Regression in 85366fbca723c9b37d0ac9db1d44e3f1cb188db2.

Backport of 182f262b15882649bbc39d769f9b721cf3660f6f from main.

comment:13 by Sarah Boyce <42296566+sarahboyce@…>, 4 months ago

In c3d3af8e:

[5.0.x] Fixed #35606, Refs #34045 -- Fixed rendering of ModelAdmin.action_checkbox for models with a html method.

Thank you Claude Paroz for the report.

Regression in 85366fbca723c9b37d0ac9db1d44e3f1cb188db2.

Backport of 182f262b15882649bbc39d769f9b721cf3660f6f from main.

Note: See TracTickets for help on using tickets.
Back to Top