Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#33971 closed Bug (fixed)

admindocs breaks the admin if it appears before the admin in INSTALLED_APPS

Reported by: Tom Carrick Owned by: Mariusz Felisiak
Component: contrib.admindocs Version: 4.1
Severity: Release blocker Keywords:
Cc: Carlton Gibson, Alokik Roy Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Maxim Danilov)


Change History (8)

comment:1 Changed 9 months ago by Tom Carrick

Summary: admindocs doesn't work if it appears before the admin in INSTALLED_APPS → admindocs breaks the admin if it appears before the admin in INSTALLED_APPS

comment:2 Changed 9 months ago by Tom Carrick

Description: modified (diff)

comment:3 Changed 9 months ago by Mariusz Felisiak

Cc: Carlton Gibson Alokik Roy added
Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted
Version: dev → 4.1

Thanks for the report! Unfortunately ​the proposed solution doesn't fix this for me, so we need to handle it separately.

Regression in 7f3cfaa12b28d15c0ca78bb692bfd6e59d17bff1.

comment:4 Changed 9 months ago by Mariusz Felisiak

Has patch: set
Owner: changed from nobody to Mariusz Felisiak
Status: new → assigned

​PR

comment:5 Changed 9 months ago by GitHub <noreply@…>

Resolution: → fixed
Status: assigned → closed

In 974942a7:

Fixed #33955, Fixed #33971 -- Reverted "Fixed #32565 -- Moved internal URLResolver view-strings mapping to admindocs."

This reverts commit 7f3cfaa12b28d15c0ca78bb692bfd6e59d17bff1.

Thanks Tom Carrick and Greg Kaleka for reports.

comment:6 Changed 9 months ago by Mariusz Felisiak <felisiak.mariusz@…>

In a108380:

[4.1.x] Fixed #33955, Fixed #33971 -- Reverted "Fixed #32565 -- Moved internal URLResolver view-strings mapping to admindocs."

This reverts commit 7f3cfaa12b28d15c0ca78bb692bfd6e59d17bff1.

Thanks Tom Carrick and Greg Kaleka for reports.
Backport of 974942a75039ba43e618f6a5ff95e08b5d5176fd from main

comment:7 Changed 9 months ago by Maxim Danilov

Description: modified (diff)

This patch war unnecessary.
with the same Effect we can remove method ready from class AdminDocsConfig(AppConfig) from django.contrib.admindocs.apps

For topik starter:
I use many times admindocs in my projects and it was easy solution: to redefine AdminDocsConfig with empty ready method.

comment:8 in reply to:  7 Changed 9 months ago by Mariusz Felisiak

Replying to Maxim Danilov:

This patch war unnecessary.
with the same Effect we can remove method ready from class AdminDocsConfig(AppConfig) from django.contrib.admindocs.apps

For topik starter:
I use many times admindocs in my projects and it was easy solution: to redefine AdminDocsConfig with empty ready method.

Removing ready() was not a proper solution because admindocs views wouldn't work without it as callbacks wouldn't be registered.

Note: See TracTickets for help on using tickets.
Back to Top