#33958 closed Cleanup/optimization (fixed)
Missing imports in "Expressions can reference transforms" section.
| Reported by: | Eido Askayo | Owned by: | Iván Triviño |
|---|---|---|---|
| Component: | Documentation | Version: | 4.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
In section Expressions can reference transforms, the following code is shown:
>>> Entry.objects.aggregate(first_published_year=Min('pub_date__year'))
There is a missing import for Min function:
>>> from django.db.models import Min
Also, the following code is shown:
>>> Entry.objects.values('pub_date__year').annotate(
... top_rating=Subquery(
... Entry.objects.filter(
... pub_date__year=OuterRef('pub_date__year')
... ).order_by('-rating').values('rating')[:1]
... ),
... total_comments=Sum('number_of_comments'))
There are missing imports for Subquery, OuterRef and Sum functions:
>>> from django.db.models import Subquery, OuterRef, Sum
Change History (4)
comment:1 by , 3 years ago
| Description: | modified (diff) |
|---|---|
| Has patch: | set |
| Owner: | changed from to |
| Patch needs improvement: | set |
| Status: | new → assigned |
| Summary: | Missing import in "Expressions can reference transforms" section → Missing imports in "Expressions can reference transforms" section. |
| Triage Stage: | Unreviewed → Accepted |
| Type: | Bug → Cleanup/optimization |
comment:2 by , 3 years ago
| Patch needs improvement: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
Thanks for the report!
PR
Ticket is not required for such a small cleanups, by the way.