Opened 3 months ago

Closed 3 months ago

#33946 closed Bug (invalid)

admin change_form field label does not use mark_safe

Reported by: Caram Owned by: nobody
Component: contrib.admin Version: 4.1
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

Example:

models.py

myfield = models.BooleanField(format_html('<i class="fa-regular fa-hourglass-half"</i>'))

generated HTML

<label class="vCheckboxLabel" for="id_myfield">&lt;i class=&quot;fa-regular fa-hourglass-half&quot;&gt;&lt;/i&gt;</label>

The issue only occurs for change_form.html. In other words, change_list.html handles this case well.

Change History (2)

comment:1 Changed 3 months ago by Alex Morega

In your example you're setting verbose_name on the myfield field. It looks like it's meant to be a string; the Verbose field names documentation implies that.

In other words, change_list.html handles this case well.

That's probably accidental. If you want a custom field label in the admin change form, you're better off customizing the ModelAdmin.form:

from django.contrib import admin
from django.forms.models import ModelForm

class MyModelForm(ModelForm):
    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        self.fields['myfield'].label = format_html(
            '<i class="fa-regular fa-hourglass-half"></i>'
        )

@admin.register(models.MyModel)
class MyModelAdmin(admin.ModelAdmin):
    form = MyModelForm

comment:2 Changed 3 months ago by Carlton Gibson

Resolution: invalid
Status: newclosed

The issue tracker is for bug reports on Django, not support requests. Please see TicketClosingReasons/UseSupportChannels for appropriate places for questions like this. (It's always possible to open a ticket if it turns out to be a bug.)

Also, Caram, please do not post to the DevelopersMailingList saying you've opened a ticket here. That just spams a whole lot of people.

Thanks.

Note: See TracTickets for help on using tickets.
Back to Top