JSONField with default is not detected as changed when invalidated in inlines.

[Raphael]

Apparently the JSONField field modification in a TabularInline is ignored after a validation error.

To reproduce I attached the generated project based of the basic Django tutorial with changes to use a JSONField and TabularInline

user: admin
password: admin

Sequence:

1. Edit the Question
2. Change both Text field to "test"
3. Change both JsonField to 'test' (Any Valid Json)
4. Save
5. Edit again
6. Change both two JsonField to 'test 123' (Any Valid Json)
7. Delete text from Text field of the second item
8. Save
9. Error message will appear
10. Set the Choice Text field to 'test 123' of the second item
11. Save
12. Edit again, only the second JsonField was changed to 'test 123' (Any Valid Json)

[Mariusz Felisiak]

Thanks for the detailed report. initial value is set to a new value when invalidated, that's why changes are not detected:

choice_set-0-test="test 123"
initial-choice_set-0-test="test 123"

[JunKi Yoon]

Replying to Mariusz Felisiak:

Is this still a bug that needs to be fixed?

[Mariusz Felisiak]

Replying to JunKi Yoon:

Is this still a bug that needs to be fixed?

Yes, it's waiting for a patch.

[JunKi Yoon]

Replying to Mariusz Felisiak:

Ok, I will try. Thank you for reply :)

[JunKi Yoon]

Replying to Raphael, Mariusz Felisiak:

Hi, Raphael. I want to patch this issue.

1. So, Could you plz give me the URL for the basic Django tutorial ?

2. And, I downloaded your attachments. I have a question about sequence you wrote. Did you run it from the admin page ? or Django shell ?

3. Did you mean, right?

   two TextField -> Question.question_text, Choice.choice_text,
   one JsonField -> Choice.test 
   

How can I reproduce ?

[Raphael]

Hello,

1. So, Could you plz give me the URL for the basic Django tutorial ?

--- ​https://docs.djangoproject.com/en/4.1/intro/tutorial01/

2. And, I downloaded your attachments. I have a question about sequence you wrote. Did you run it from the admin page ? or Django shell ?

-- Admin page

3. Did you mean, right?

-- I didn't really understand the question, but in the sample I attached is another field. I don't think this is relevant to the problem. I think it's easier for you to use the sample I sent.

How can I reproduce ?

Run the code and follow the Sequence. You will see that the data will not be store correctly.

Thank you.

Replying to JunKi Yoon:

Replying to Raphael, Mariusz Felisiak:

Hi, Raphael. I want to patch this issue.

1. So, Could you plz give me the URL for the basic Django tutorial ?

2. And, I downloaded your attachments. I have a question about sequence you wrote. Did you run it from the admin page ? or Django shell ?

3. Did you mean, right?

   two TextField -> Question.question_text, Choice.choice_text,
   one JsonField -> Choice.test 
   

How can I reproduce ?

[JunKi Yoon]

Replying to Mariusz Felisiak:

Hi Mariusz Felisiak :)

After debugging, I confirmed that the initial-choice_set-0-test and choice_set-0-test are same. (same initial-choice_set-0-test, choice_set-1-test)
And then, They don't have changed_data. That's why the issue.

So, I guess one thing. initial-choice_set-0-test is not the value that the Choice object currently has.
initial-choice_set-0-test value after showing error message by sequence 8 is stored as the input value in sequence 6.

Could you plz give me some advice regarding where to set the initial-XXX-XXX and code?

Thank you.

cc) Raphael

Thanks for the detailed report. initial value is set to a new value when invalidated, that's why changes are not detected:

choice_set-0-test="test 123"
initial-choice_set-0-test="test 123"

[Jacob Walls]

​PR

[Carlton Gibson]

Current patch is mixing solution between forms and admin components. Slightly clearer tests showing the problem would probably clarify.

[JunKi Yoon]

Replying to Carlton Gibson:

Current patch is mixing solution between forms and admin components. Slightly clearer tests showing the problem would probably clarify.

I Improved patch and tests. :)

[Mariusz Felisiak]

Duplicate of #34119.

[David Sanders]

Confirmed the patch for #34119 fixes the issue with sample models provided and steps described above.