Support pathlib.Path in loaders' get_template().

[simon klemenc]

Since pathlib is the modern approach to file-paths we should probably support pathlib.Path in all template loaders

affected PRs:
​https://github.com/jrief/django-admin-sortable2/issues/320
​https://github.com/django/django/pull/15835

[Mariusz Felisiak]

Seems reasonable. Thanks.

[Mariusz Felisiak]

​PR

[David Smith]

I am not sure we need to support pathlib.Path?

In the first example there is:

os.path.join('adminsortable2', app_label, opts.model_name, 'change_list.html'),

os.path.join returns a str. If it wanted to be remove the use of os I think string concatenation using f-string or %-format would also work? e.g.

f'adminsortable2/{app_label}/{opts.model_name}/change_list.html'

Assuming, my above statement is correct. Is there a concrete example where using pathlib.Path over string concatenation is preferable?

I'm also thinking about Jinja2 given the original PR targeted that backend. It's docs say that the template name should be a str or Template. I'm not sure it's Django's responsibility to enhance that API to do conversion of Paths?
​https://jinja.palletsprojects.com/en/3.1.x/api/#jinja2.Environment.get_template.

[Carlton Gibson]

TBH I think I'm -1 on this as well.

I see no benefit in loosening the accepted type on the template_name argument, from str to Union[str, Path] as in the draft PR.
It's a looser API, that doesn't match the underlying expectations, as David points out.

I'd suggest casting to str as a last step if want to use pathlib for the manipulations.

[Mariusz Felisiak]

Agreed with David and Carlton.

Simon, please ​follow the triaging guidelines with regards to wontfix tickets and take this to DevelopersMailingList if you don't agree.

[Carlton Gibson]

I'll just note, the API contract here isn't to paths but to template names. Really it's an implementation detail of the loaders that those names map to the file system. A DB-based loader (say) would be free to adopt a totally different naming scheme, such that getting passed pathlib.Path instances would be unexpected, shall we say.