Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#33829 closed Bug (fixed)

BaseConstraint.deconstruct() and __eq__ operators don't take violation_error_message into account.

Reported by: Mariusz Felisiak Owned by: Stéphane "Twidi" Angel
Component: Database layer (models, ORM) Version: 4.1
Severity: Release blocker Keywords:
Cc: Gagaro Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Thanks Stéphane "Twidi" Angel for the report.

Regression in 667105877e6723c6985399803a364848891513cc.

Change History (7)

comment:1 Changed 7 months ago by Mariusz Felisiak

Has patch: set

comment:2 Changed 7 months ago by Mariusz Felisiak

Summary: BaseConstraint.deconstruct() doesn't take violation_error_message into account.BaseConstraint.deconstruct() and __eq__ operators don't take violation_error_message into account.

comment:3 Changed 7 months ago by Mariusz Felisiak

Needs tests: set
Patch needs improvement: set

comment:4 Changed 7 months ago by Stéphane "Twidi" Angel

Here is the Pull request

comment:5 Changed 7 months ago by Mariusz Felisiak

Needs tests: unset
Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:6 Changed 7 months ago by Mariusz Felisiak <felisiak.mariusz@…>

Resolution: fixed
Status: assignedclosed

In ccbf714:

Fixed #33829 -- Made BaseConstraint.deconstruct() and equality handle violation_error_message.

Regression in 667105877e6723c6985399803a364848891513cc.

comment:7 Changed 7 months ago by Mariusz Felisiak <felisiak.mariusz@…>

In a3d35af:

[4.1.x] Fixed #33829 -- Made BaseConstraint.deconstruct() and equality handle violation_error_message.

Regression in 667105877e6723c6985399803a364848891513cc.

Backport of ccbf714ebeff51d1370789e5e487a978d0e2dbfb from main

Note: See TracTickets for help on using tickets.
Back to Top