Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#33829 closed Bug (fixed)

BaseConstraint.deconstruct() and __eq__ operators don't take violation_error_message into account.

Reported by: Mariusz Felisiak Owned by: Stéphane "Twidi" Angel
Component: Database layer (models, ORM) Version: 4.1
Severity: Release blocker Keywords:
Cc: Gagaro Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Thanks Stéphane "Twidi" Angel for the report.

Regression in 667105877e6723c6985399803a364848891513cc.

Change History (8)

comment:1 by Mariusz Felisiak, 3 years ago

Has patch: set

​PR

comment:2 by Mariusz Felisiak, 3 years ago

Summary: BaseConstraint.deconstruct() doesn't take violation_error_message into account. → BaseConstraint.deconstruct() and __eq__ operators don't take violation_error_message into account.

comment:3 by Mariusz Felisiak, 3 years ago

Needs tests: set
Patch needs improvement: set

comment:4 by Stéphane "Twidi" Angel, 3 years ago

Here is the ​Pull request

comment:5 by Mariusz Felisiak, 3 years ago

Needs tests: unset
Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In ccbf714:

Fixed #33829 -- Made BaseConstraint.deconstruct() and equality handle violation_error_message.

Regression in 667105877e6723c6985399803a364848891513cc.

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In a3d35af:

[4.1.x] Fixed #33829 -- Made BaseConstraint.deconstruct() and equality handle violation_error_message.

Regression in 667105877e6723c6985399803a364848891513cc.

Backport of ccbf714ebeff51d1370789e5e487a978d0e2dbfb from main

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

In 51c9bb7:

Refs #33829 -- Added violation_error_message to constraints' repr().

Note: See TracTickets for help on using tickets.
Back to Top