Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#33800 closed Bug (fixed)

check_for_template_tags_with_the_same_name with libraries in TEMPLATES

Reported by: Claude Paroz Owned by: Mariusz Felisiak
Component: Template system Version: 4.1
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I didn't explore this thoroughly, but I think there might be an issue with the check_for_template_tags_with_the_same_name when you add a template tag library into TEMPLATES['OPTIONS']['librairies'].

I'm getting an error like:
(templates.E003) 'my_tags' is used for multiple template tag modules: 'someapp.templatetags.my_tags', 'someapp.templatetags.my_tags'

Change History (4)

comment:1 by Mariusz Felisiak, 3 years ago

Component: Uncategorized → Template system
Owner: changed from nobody to Mariusz Felisiak
Severity: Normal → Release blocker
Status: new → assigned

Thanks for the report. It's a bug in the new system check (see 004b4620f6f4ad87261e149898940f2dcd5757ef and #32987).

comment:2 by Mariusz Felisiak, 3 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted

​PR

comment:3 by GitHub <noreply@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In 083bfca6:

Fixed #33800 -- Fixed system check for the same template tag module in installed apps and template tag libraries.

Thanks Claude Paroz for the report.

Regression in 004b4620f6f4ad87261e149898940f2dcd5757ef.

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In b37a4af:

[4.1.x] Fixed #33800 -- Fixed system check for the same template tag module in installed apps and template tag libraries.

Thanks Claude Paroz for the report.

Regression in 004b4620f6f4ad87261e149898940f2dcd5757ef.
Backport of 083bfca6b6c00d0f45837a65c2db721eaf46bc07 from main

Note: See TracTickets for help on using tickets.
Back to Top