Opened 2 years ago

Closed 2 years ago

Last modified 20 months ago

#33781 closed Bug (fixed)

Timezone warning visual regression.

Reported by: Mariusz Felisiak Owned by: Carlton Gibson
Component: contrib.admin Version: dev
Severity: Release blocker Keywords:
Cc: Carlton Gibson, Florian Demmer Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Mariusz Felisiak)

Unfortunately, f3e2bb0833105f43efc0cc6f19c8465bc1b1a785 introduced a regression in admin which still uses <p> for ​split datetimes.

Before:


After f3e2bb0833105f43efc0cc6f19c8465bc1b1a785:


Attachments (2)

after.png​ (18.0 KB ) - added by Mariusz Felisiak 2 years ago.
before.png​ (18.1 KB ) - added by Mariusz Felisiak 2 years ago.

Download all attachments as: .zip

Change History (10)

by Mariusz Felisiak, 2 years ago

Attachment: after.png​ added

by Mariusz Felisiak, 2 years ago

Attachment: before.png​ added

comment:1 by Mariusz Felisiak, 2 years ago

Description: modified (diff)

comment:2 by Carlton Gibson, 2 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Yahya Ali, 2 years ago

Owner: changed from nobody to Yahya Ali
Status: new → assigned

comment:4 by Carlton Gibson, 2 years ago

Has patch: set
Owner: changed from Yahya Ali to Carlton Gibson

​PR adjusting the CSS.

comment:5 by Mariusz Felisiak, 2 years ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Carlton Gibson <carlton@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In 6f80050:

Fixed #33781 -- Restored alignment for admin split-field timezone warnings.

Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.
Refs #33750 and #27207.

comment:7 by GitHub <noreply@…>, 20 months ago

In 73ae854:

Refs #33781 -- Restored alignment for admin split-field timezone warnings for RTL languages.

Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 20 months ago

In 12561b70:

[4.2.x] Refs #33781 -- Restored alignment for admin split-field timezone warnings for RTL languages.

Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.
Backport of 73ae8545ae620469550f1adcfe63fb9b9e4f3eb3 from main

Note: See TracTickets for help on using tickets.
Back to Top