Opened 10 years ago

Closed 10 years ago

#3377 closed (fixed)

[patch] Infinite loop in LazyDate

Reported by: Brut[all] <brut.alll@…> Owned by: Adrian Holovaty
Component: Database layer (models, ORM) Version: master
Severity: Keywords: LazyDate pickle
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

__getattr__ and __get_value__ methods of LazyDate creates infinite recursion if object hasn't got a delta attribute. Normally it shouldn't happen, but in some case, for example if we try to unpickle LazyDate object, it starts looping.

Attachments (2)

__init__.py (2.1 KB) - added by Brut[all] <brut.alll@…> 10 years ago.
__init__.diff (513 bytes) - added by Brut[all] <brut.alll@…> 10 years ago.
Sorry for that above. I hope this will be ok.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Brut[all] <brut.alll@…>

Attachment: __init__.py added

Changed 10 years ago by Brut[all] <brut.alll@…>

Attachment: __init__.diff added

Sorry for that above. I hope this will be ok.

comment:1 Changed 10 years ago by Simon G. <dev@…>

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Summary: Infinite loop in LazyDate[patch] Infinite loop in LazyDate
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 10 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [4497]) Fixed #3377 -- Fixed subtle infinite recursion bug in LazyDate objects. Thanks
to brut.alll@….

Note: See TracTickets for help on using tickets.
Back to Top