Opened 6 months ago

Last modified 4 months ago

#33728 closed Cleanup/optimization

Tab order should match visual order for admin model forms’ submit buttons — at Version 1

Reported by: Thibaud Colas Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords: accessibility, keyboard, ux
Cc: Carlton Gibson, elky Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Thibaud Colas)

In the Django admin, in a model form, the tab order of the submit buttons is different from the visual order. Here is a screenshot of the tab stops:

https://code.djangoproject.com/raw-attachment/ticket/33728/tab-stop-modelform.png

In LTR languages, focus should follow the reading order of the page, top-to-bottom, left to right. Here, the correct focus order for those buttons would be:

  1. Save and add another
  2. Save and continue editing
  3. SAVE (not sure why this one is shouting)

We need to change the order of the buttons in the DOM so it matches the visual order. Or if we do want the default button to be reached first, then remove the styling that changes the visual order currently. I assume this implementation was done intentionally, but it’s confusing for keyboard users if focus moves counter to the expected sequential flow of the elements.

Change History (2)

Changed 6 months ago by Thibaud Colas

Attachment: tab-stop-modelform.png added

comment:1 Changed 6 months ago by Thibaud Colas

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top