#33725 closed Bug (fixed)
Admin sidebar’s filter field should not receive focus when sidebar is closed.
| Reported by: | Thibaud Colas | Owned by: | Sankalp |
|---|---|---|---|
| Component: | contrib.admin | Version: | 4.0 |
| Severity: | Release blocker | Keywords: | accessibility, keyboard, tab stop |
| Cc: | Tom Carrick, Maxim Milovanov | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | yes |
Description (last modified by )
In the Django admin, when I toggle the sidebar to have it closed, my keyboard focus going from the header to the page still disappears for one tab stop. This is tab stop 8 in the following screenshot:
Upon inspection, this seems to be the sidebar’s "Start typing to filter…" field. Since the field is hidden, it shouldn’t be possible to tab to it. The whole contents of the sidebar should be invisible and inert.
Attachments (1)
Change History (14)
Changed 13 months ago by
| Attachment: | nav-filter-tab-stops.png added |
|---|
comment:1 Changed 13 months ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 13 months ago by
| Cc: | Tom Carrick Maxim Milovanov added |
|---|---|
| Severity: | Normal → Release blocker |
| Summary: | Admin sidebar’s filter field should not receive focus when sidebar is closed → Admin sidebar’s filter field should not receive focus when sidebar is closed. |
| Triage Stage: | Unreviewed → Accepted |
| Version: | dev → 4.0 |
Thanks for the report.
Regression in d915dd1c5809d7c2bb3679751cd5277571dcd9f7.
Follow up to 780473d75625d014cbe9b0acdea40b7a5970d5d8.
comment:3 Changed 13 months ago by
| Easy pickings: | set |
|---|
comment:4 Changed 13 months ago by
| Owner: | changed from nobody to Sankalp |
|---|---|
| Status: | new → assigned |
comment:5 Changed 13 months ago by
Toggling tabIndex on <input id="nav-filter" ...> should do the trick here (see a similar solution for links in the sidebar, 780473d75625d014cbe9b0acdea40b7a5970d5d8.)
comment:7 Changed 13 months ago by
| Has patch: | set |
|---|
comment:8 Changed 13 months ago by
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note: See
TracTickets for help on using
tickets.
Screenshot of the django admin in dark mode, with tab stops visualisation showing a stop on an invisible element