Opened 10 years ago

Closed 10 years ago

#3368 closed (fixed)

Add USStateField and PhoneNumberfield to django.newforms.fields

Reported by: jkocherhans Owned by: Adrian Holovaty
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The summary says it all.

Attachments (1)

newforms-new-fields.diff (3.9 KB) - added by jkocherhans 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by jkocherhans

Needs documentation: unset
Needs tests: set
Patch needs improvement: unset

comment:2 Changed 10 years ago by Marc Fargas <telenieko@…>

Hi jkocherhans,
Please take a look at this thread almost the same could apply for newforms fields.

But anyway, maybe instead of creating a new field type, why don't you create a new widget? In this case I think a widget makes more sense than a field.

comment:3 Changed 10 years ago by Marc Fargas <telenieko@…>

Triage Stage: UnreviewedDesign decision needed

comment:4 in reply to:  2 Changed 10 years ago by jkocherhans

Replying to Marc Fargas <telenieko@telenieko.com>:

Hi jkocherhans,
Please take a look at this thread almost the same could apply for newforms fields.

But anyway, maybe instead of creating a new field type, why don't you create a new widget? In this case I think a widget makes more sense than a field.

Oh yes. I knew I saw that thread :) I think USStateField and PhoneNumberField are still things we're going to want regardless of how they are implemented. They are core django model fields and AFAIK aren't going away anytime soon. I don't think a widget would work here. We're talking about validation, not display.

Changed 10 years ago by jkocherhans

Attachment: newforms-new-fields.diff added

comment:5 Changed 10 years ago by jkocherhans

Needs tests: unset

comment:6 Changed 10 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

We've got both of these fields now.

Note: See TracTickets for help on using tickets.
Back to Top