Opened 18 years ago
Closed 18 years ago
#3368 closed (fixed)
Add USStateField and PhoneNumberfield to django.newforms.fields
Reported by: | jkocherhans | Owned by: | Adrian Holovaty |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Design decision needed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The summary says it all.
Attachments (1)
Change History (7)
comment:1 by , 18 years ago
Needs tests: | set |
---|
follow-up: 4 comment:2 by , 18 years ago
comment:3 by , 18 years ago
Triage Stage: | Unreviewed → Design decision needed |
---|
comment:4 by , 18 years ago
Replying to Marc Fargas <telenieko@telenieko.com>:
Hi jkocherhans,
Please take a look at this thread almost the same could apply for newforms fields.
But anyway, maybe instead of creating a new field type, why don't you create a new widget? In this case I think a widget makes more sense than a field.
Oh yes. I knew I saw that thread :) I think USStateField
and PhoneNumberField
are still things we're going to want regardless of how they are implemented. They are core django model fields and AFAIK aren't going away anytime soon. I don't think a widget would work here. We're talking about validation, not display.
by , 18 years ago
Attachment: | newforms-new-fields.diff added |
---|
comment:5 by , 18 years ago
Needs tests: | unset |
---|
comment:6 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
We've got both of these fields now.
Hi jkocherhans,
Please take a look at this thread almost the same could apply for newforms fields.
But anyway, maybe instead of creating a new field type, why don't you create a new widget? In this case I think a widget makes more sense than a field.