Opened 3 years ago

Closed 3 years ago

#33679 closed Bug (fixed)

"empty" suffix gets added to last (original) admin inline form row for readonly views

Reported by: Daniel Hahler Owned by: Daniel Hahler
Component: contrib.admin Version: 4.0
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

django/contrib/admin/templates/admin/edit_inline/tabular.html has the following code:

        <tr class="form-row {% if inline_admin_form.original or inline_admin_form.show_url %}has_original{% endif %}{% if forloop.last and inline_admin_formset.has_add_permission %} empty-form{% endif %}"
             id="{{ inline_admin_formset.formset.prefix }}-{% if not forloop.last %}{{ forloop.counter0 }}{% else %}empty{% endif %}">

The condition for adding the "empty" suffix to the id does not work when the object is readonly (no has_add_permission).

I think it should use the same condition as with the handling of the empty-form class.

The empty row gets added based on this in the first place: ​https://github.com/django/django/blob/f97401d1b184406d2e24f11eddbdaca8bbc360e3/django/contrib/admin/helpers.py#L299-L304

ref (added in): ​https://github.com/django/django/commit/825f0beda804e48e9197fcf3b0d909f9f548aa47#diff-3bed8380f4461efe8e7ec596937f85def59b1e38dcd6edd6e7f76c7a45d53f02

Change History (3)

comment:1 by Mariusz Felisiak, 3 years ago

Has patch: set
Owner: changed from nobody to Daniel Hahler
Status: new → assigned
Triage Stage: Unreviewed → Accepted

Good catch!

​PR

comment:2 by Mariusz Felisiak, 3 years ago

Triage Stage: Accepted → Ready for checkin

comment:3 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In dddc8bc:

Fixed #33679 -- Fixed the last inline's id in admin for users without add permissions.

Note: See TracTickets for help on using tickets.
Back to Top