Opened 2 years ago

Closed 2 years ago

#33654 closed Cleanup/optimization (fixed)

Missed function in __all__ in timezone.py

Reported by: Andrey Otto Owned by: Andrey Otto
Component: Utilities Version: 4.0
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Carlton Gibson)

In some reason in timezone.py file missed localdate() function in __all__ list. Because of this PyCharm (for example) highlights import of localdate.

https://code.djangoproject.com/raw-attachment/ticket/33654/django_pycharm.png

Attachments (1)

django_pycharm.png​ (4.0 KB ) - added by Andrey Otto 2 years ago.

Download all attachments as: .zip

Change History (8)

by Andrey Otto, 2 years ago

Attachment: django_pycharm.png​ added

comment:1 by Carlton Gibson, 2 years ago

Owner: changed from Andrey Otto to Carlton Gibson
Triage Stage: Unreviewed → Accepted

OK, yep, it's documented, so should likely be included in __all__. Thanks

comment:2 by Carlton Gibson, 2 years ago

Has patch: set

​PR

comment:3 by Carlton Gibson, 2 years ago

Already there Andrey. ​PR 🙂

comment:4 by Carlton Gibson, 2 years ago

Owner: changed from Carlton Gibson to Andrey Otto

comment:5 by Carlton Gibson, 2 years ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Carlton Gibson, 2 years ago

Description: modified (diff)

comment:7 by GitHub <noreply@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In 420d13e:

Fixed #33654 -- Added localdate to utils.timezone.all.

Note: See TracTickets for help on using tickets.
Back to Top