#33571 closed Bug (fixed)
Fix handling empty string for If-Modified-Since header
| Reported by: | Collin Anderson | Owned by: | Collin Anderson |
|---|---|---|---|
| Component: | HTTP handling | Version: | 4.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Empty string used to be ignored for If-Modified-Since header, but now raises exception since d6aff369ad3.
Change History (6)
comment:1 by , 3 years ago
| Has patch: | set |
|---|
comment:2 by , 3 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
| Triage Stage: | Unreviewed → Accepted |
Thanks for the report.
Regression in d6aff369ad33457ae2355b5b210faf1c4890ff35.
follow-up: 5 comment:4 by , 3 years ago
I guess this has been broken since 3.1. Any chance this could be backported? At least to 4.0? (Feel free to leave in catching AssertionError) I suppose it would need a release note too.
comment:5 by , 3 years ago
Replying to Collin Anderson:
I guess this has been broken since 3.1. Any chance this could be backported? At least to 4.0? (Feel free to leave in catching
AssertionError) I suppose it would need a release note too.
This is a regression in Django 3.1 which is not supported anymore. Per our backporting policy this means it doesn't qualify for a backport to 4.0.x or 3.2.x anymore. See Django’s release process for more details.
comment:6 by , 3 years ago
Could it maybe be considered a "Crashing bug", because it crashes rather than ignores a bad value? If not that's fine. I suppose most people follow the advice in the docs and don't use django.views.static.serve() in production. :)
Pull Request: https://github.com/django/django/pull/15498