Rows are selected only on Chrome when going back from the confirmation page.

[Akihito Yokose]

On the admin site, I've found a feature that existed in Django 2.2 but was lost with the update to Django 3.2.

In Django 2.2, if you clicked the "No, take me back" button on the delete confirmation page, the background color of the checked rows would remain highlighted and the action-counter display would remain counted up on the change list page. However, in Django 3.2, the background color of the selected row is not highlighted and the action-counter display is "0 of X selected" (see attached images).

The reason for this is probably that the following process in django/contrib/admin/static/admin/js/actions.js was removed during the update to Django 3.2.

// Show counter by default
$(options.counterContainer).show();
// Check state of checkboxes and reinit state if needed
$(this).filter(":checked").each(function(i) {
    $(this).parent().parent().toggleClass(options.selectedClass);
    updateCounter();
    if ($(options.acrossInput).val() === 1) {
        showClear();
    }
});

A related Issue is ​https://github.com/django/django/pull/12820.

[Mariusz Felisiak]

For me, it works exactly the same in Django 2.2 and 3.2, in both cases rows are not highlighted or selected. Can you provide a sample project that reproduces this issue?

[Akihito Yokose]

Mariusz, thanks for the info.

It may depend on your browser.
The results I checked on my Windows PC are as follows.

Chrome 98 and Edge 98:

• Django 2.2: OK
• Django 3.2: NG

However, the situation was different with Firefox.

Firefox 96:

• Django 2.2: NG
• Django 3.2: NG

[Mariusz Felisiak]

Thanks for details. I'd say it wasn't an intended feature, since it's browser specific. IMO, we should enforce clearing checkboxes, instead of highlighting rows on Chrome. This would make this behavior browser-agnostic.

[Marcelo Galigniana]

​PR

[Carlton Gibson <carlton@…>]

In 0aa2f16e:

Fixed #33491 -- Fixed change-list selected row-highlight on cancelled delete.

Selected rows where not highlighted when returning to the change-list
after clicking "No, take me back" on the deletion confirmation page.

This commit uses the CSS :has() pseudo-class to apply the highlight
without requiring the .selected class, which is added by JavaScript
on the click event.

Once all supported browsers have :has() available, the .selected
selector and the JavaScript to add the class can be removed.

Co-authored-by: Carlton Gibson <carlton.gibson@…>

[Carlton Gibson <carlton@…>]

In e1056ed5:

Refs #33491 -- Split CSS selected-row highlight selectors.

Combined selectors break the whole rule where :has() is not supported,
for example on Firefox.

Thanks to Marcelo Galigniana for the report.