Opened 2 years ago

Closed 2 years ago

#33470 closed Cleanup/optimization (wontfix)

Avoid SQL comments with descriptions of noop operations in sqlmigrate.

Reported by: David Szotten Owned by: nobody
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


for migrations that have no effect on the db (e.g. changing choices), sqlmigrate still outputs a bunch of text, e.g.

-- Alter field name on Author

should we stop doing this?

Change History (1)

comment:1 by Mariusz Felisiak, 2 years ago

Resolution: wontfix
Status: newclosed
Summary: no-op sqlmigrate outputAvoid SQL comments with descriptions of noop operations in sqlmigrate.
Type: UncategorizedCleanup/optimization

Thanks for the ticket. I don't see anything wrong in keeping descriptions of operations for no-ops. It's helpful in confirming that all operations have been processed by migrations, and in finding out which operations are no-ops. Also, these comments and generated SQL are on different layers (migrations vs. schema editor) so it might be difficult to implement. I don't think it's worth additional complexity.

Note: See TracTickets for help on using tickets.
Back to Top