Opened 2 years ago

Closed 2 years ago

#33457 closed Bug (fixed)

Expanding local vars in technical 500 causes horizontal scrolling

Reported by: Keryn Knight Owned by: Hrushikesh Vaidya
Component: Error reporting Version: dev
Severity: Normal Keywords: technical debug 500 UI
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

Whilst working on a little alpha project to provide alternate error pages, and comparing output, I noticed that expanding the Local vars seems to always cause a horizontal scrollbar, at least at 1425x???? in Chrome.

As far as I can tell from checking out git tags, this seems to occur at least back to 2.2 (???? that can't be right, but OK!), and before that I start getting issues with code which has moved that my project doesn't support, so ... it may go back further.

A cursory play around with my devtools suggests that the following fixes it:

table.vars {
    margin: 5px 10px 2px 40px;
    width: auto;
}

Specifically:

  • Restore the width to not be 100% (which is currently applied to all table) and use auto or inherit or initial instead.
  • Add 10px right margin so the table lines up vertically with it's related context lines.

Attaching a gif which shows a slice of the issue.

Attachments (1)

te500-scroll.gif (47.9 KB ) - added by Keryn Knight 2 years ago.
animated gif showing the table's end being off-screen, forcing an horizontal scrollbar to appear when Local vars are toggled

Download all attachments as: .zip

Change History (5)

by Keryn Knight, 2 years ago

Attachment: te500-scroll.gif added

animated gif showing the table's end being off-screen, forcing an horizontal scrollbar to appear when Local vars are toggled

comment:1 by Hrushikesh Vaidya, 2 years ago

Has patch: set
Owner: set to Hrushikesh Vaidya
Status: newassigned
UI/UX: set

comment:2 by Mariusz Felisiak, 2 years ago

Triage Stage: UnreviewedAccepted

Thanks for the report.

comment:3 by Mariusz Felisiak, 2 years ago

Triage Stage: AcceptedReady for checkin

comment:4 by GitHub <noreply@…>, 2 years ago

Resolution: fixed
Status: assignedclosed

In 89d137f3:

Fixed #33457 -- Fixed "Local vars" scrolling in technical 500 debug page.

Thanks Keryn Knight for the report and the initial patch.

Note: See TracTickets for help on using tickets.
Back to Top