Changes between Version 2 and Version 5 of Ticket #33434


Ignore:
Timestamp:
Jan 13, 2022, 5:41:17 PM (3 years ago)
Author:
Thibaud Colas
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #33434

    • Property Triage Stage Unreviewed → Accepted
    • Property Owner changed from nobody to ravi kunwar
    • Property Status new → assigned

  • Ticket #33434 – Description

    v2 v5  
    22222. Refactoring all font-size definitions to `rem`, even the ones already relative using keywords (`small`), `em`, and % units. This is just because `rem` definitions are much simpler to reason about, since the sizes are only relative to the `html` root. There are a few cases where `em` still have a place but they should be the (very rare) exception.
    23233. Enforcing `px` are never used for `font-size` with [https://stylelint.io/ stylelint] running in continuous integration, and its [https://stylelint.io/user-guide/rules/list/declaration-property-unit-disallowed-list/ declaration-property-unit-disallowed-list] rule.
     244. Increasing the font size across the board. Personally I’d recommend 14px as the minimum, and either 16 or 18px for "body copy".
    2425
    2526All of the above would warrant their own separate ticket, so I’m just proposing this here for others’ consideration. If there is some consensus, please go ahead with opening the corresponding ticket, or I’m happy to.
Back to Top