Changes between Version 1 and Version 2 of Ticket #33434
- Timestamp:
- Jan 12, 2022, 4:54:30 PM (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #33434 – Description
v1 v2 21 21 1. Creating an official CSS code style documentation for Django, under [https://docs.djangoproject.com/en/4.0/internals/contributing/writing-code/ Writing code]. This would cover considerations like appropriate units to use. 22 22 2. Refactoring all font-size definitions to `rem`, even the ones already relative using keywords (`small`), `em`, and % units. This is just because `rem` definitions are much simpler to reason about, since the sizes are only relative to the `html` root. There are a few cases where `em` still have a place but they should be the (very rare) exception. 23 3. Enforcing `px` are never used for `font-size` with [https://stylelint.io/ stylelint] running in continuous integration, and its [https://stylelint.io/user-guide/rules/list/declaration-property-unit-disallowed-list/ declaration-property-unit-disallowed-list rule].23 3. Enforcing `px` are never used for `font-size` with [https://stylelint.io/ stylelint] running in continuous integration, and its [https://stylelint.io/user-guide/rules/list/declaration-property-unit-disallowed-list/ declaration-property-unit-disallowed-list] rule. 24 24 25 25 All of the above would warrant their own separate ticket, so I’m just proposing this here for others’ consideration. If there is some consensus, please go ahead with opening the corresponding ticket, or I’m happy to.