Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#33419 closed Bug (fixed)

forms.Field.help_text shouldn't be HTML-escaped when form is rendered with as_ul(), as_p(), as_table().

Reported by: Mariusz Felisiak Owned by: David Smith
Component: Forms Version: 4.0
Severity: Release blocker Keywords:
Cc: David Smith, Johannes Maron, Carlton Gibson Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Mariusz Felisiak)

forms.Field.help_text shouldn't be HTML-escaped (as ​documented) when form is rendered with as_ul(), as_p(), as_table() helpers.

Thanks Matt Westcott for the ​report.

Regression in 456466d932830b096d39806e291fe23ec5ed38d5.

Change History (7)

comment:1 by Mariusz Felisiak, 4 years ago

Summary: forms.Field.help_text shouldn't be HTML-escaped when form rendered with as_ul(), as_p(), as_table() helpers. → forms.Field.help_text shouldn't be HTML-escaped when form is rendered with as_ul(), as_p(), as_table().

comment:2 by David Smith, 4 years ago

Owner: changed from nobody to David Smith
Status: new → assigned

comment:3 by Mariusz Felisiak, 4 years ago

Description: modified (diff)

comment:4 by David Smith, 4 years ago

Has patch: set

​PR

Last edited 4 years ago by Mariusz Felisiak (previous) (diff)

comment:5 by Mariusz Felisiak, 4 years ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 4c60c3e:

Fixed #33419 -- Restored marking forms.Field.help_text as HTML safe.

Regression in 456466d932830b096d39806e291fe23ec5ed38d5.

Thanks Matt Westcott for the report.

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In c959aa9:

[4.0.x] Fixed #33419 -- Restored marking forms.Field.help_text as HTML safe.

Regression in 456466d932830b096d39806e291fe23ec5ed38d5.

Thanks Matt Westcott for the report.

Backport of 4c60c3edff4312303e1021fca47ed52c2152d285 from main

Note: See TracTickets for help on using tickets.
Back to Top