Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#33407 closed Bug (fixed)

Radiolist etc. styling has changed since it's using div elements not ul elements

Reported by: Matthias Kestenholz Owned by: Carlton Gibson
Component: contrib.admin Version: 4.0
Severity: Release blocker Keywords:
Cc: David Smith Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Change History (7)

comment:1 Changed 11 months ago by Mariusz Felisiak

Cc: David Smith added
Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted

Thanks for the report, good catch! We should update CSS styles and rename django.contrib.admin.options.get_ul_class() hook (this can be done as a cleanup on the main branch).

Regression in 5942ab5eb165ee2e759174e297148a40dd855920.

comment:2 Changed 11 months ago by Mohamed Nabil Rady

Owner: changed from nobody to Mohamed Nabil Rady
Status: newassigned

comment:3 Changed 11 months ago by Mariusz Felisiak

Has patch: set
Needs documentation: set
Patch needs improvement: set

comment:4 Changed 11 months ago by Carlton Gibson

Needs documentation: unset
Owner: changed from Mohamed Nabil Rady to Carlton Gibson
Patch needs improvement: unset

comment:5 Changed 11 months ago by Mariusz Felisiak

Triage Stage: AcceptedReady for checkin

comment:6 Changed 11 months ago by Carlton Gibson <carlton.gibson@…>

Resolution: fixed
Status: assignedclosed

In 85f2a9fb:

Fixed #33407 -- Fixed .radiolist admin CSS.

Regression in 5942ab5eb165ee2e759174e297148a40dd855920.

comment:7 Changed 11 months ago by Carlton Gibson <carlton.gibson@…>

In f82ca84:

[4.0.x] Fixed #33407 -- Fixed .radiolist admin CSS.

Regression in 5942ab5eb165ee2e759174e297148a40dd855920.

Backport of 85f2a9fb0f0973930abc84a725bc30703aa3d98b from main

Note: See TracTickets for help on using tickets.
Back to Top