#33407 closed Bug (fixed)
Radiolist etc. styling has changed since it's using div elements not ul elements
| Reported by: | Matthias Kestenholz | Owned by: | Carlton Gibson |
|---|---|---|---|
| Component: | contrib.admin | Version: | 4.0 |
| Severity: | Release blocker | Keywords: | |
| Cc: | David Smith | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The ul.radiolist styles (https://github.com/django/django/blob/0ab58c120939093fea90822f376e1866fc714d1f/django/contrib/admin/static/admin/css/forms.css#L40) aren't applied anymore since https://github.com/django/django/commit/5942ab5eb165ee2e759174e297148a40dd855920
Django 3.2:
Django 4.0:
Change History (7)
comment:1 Changed 15 months ago by
| Cc: | David Smith added |
|---|---|
| Severity: | Normal → Release blocker |
| Triage Stage: | Unreviewed → Accepted |
comment:2 Changed 15 months ago by
| Owner: | changed from nobody to Mohamed Nabil Rady |
|---|---|
| Status: | new → assigned |
comment:3 Changed 15 months ago by
| Has patch: | set |
|---|---|
| Needs documentation: | set |
| Patch needs improvement: | set |
comment:4 Changed 14 months ago by
| Needs documentation: | unset |
|---|---|
| Owner: | changed from Mohamed Nabil Rady to Carlton Gibson |
| Patch needs improvement: | unset |
comment:5 Changed 14 months ago by
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note: See
TracTickets for help on using
tickets.
Thanks for the report, good catch! We should update CSS styles and rename
django.contrib.admin.options.get_ul_class()hook (this can be done as a cleanup on themainbranch).Regression in 5942ab5eb165ee2e759174e297148a40dd855920.