Opened 2 years ago

Closed 2 years ago

#33300 closed Bug (fixed)

Hidden fields are visible on small screens.

Reported by: Maxim Danilov Owned by: Shubh Parmar
Component: contrib.admin Version: 4.0
Severity: Normal Keywords: admin, modeladmin, css
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Mariusz Felisiak)

hidden admin field has wrapped div:

<div class="fieldBox field-value_char hidden">...</div>

it is should be hidden: base.css, 302 row

.hidden {
    display: none;
}

But not for small screen: responsive.css, 559 row

@media (max-width: 767px)
.aligned .form-row, .aligned .form-row > div {
    display: flex;
    ...
}

Change History (7)

comment:1 by Mariusz Felisiak, 2 years ago

Description: modified (diff)
Has patch: set
Owner: changed from nobody to xdqc
Status: new → assigned
Summary: admin form hidden field css error. → Hidden fields are visible on small screens.
UI/UX: set

Thanks for the report.

​PR

comment:2 by Mariusz Felisiak, 2 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Mariusz Felisiak, 2 years ago

Needs tests: set

comment:4 by Shubh Parmar, 2 years ago

Owner: changed from xdqc to Shubh Parmar

I will add the required test for this patch

comment:6 by Mariusz Felisiak, 2 years ago

Needs tests: unset
Triage Stage: Accepted → Ready for checkin

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In aecfc40c:

Fixed #33300 -- Ensured hidden elements are not displayed on small screens.

Note: See TracTickets for help on using tickets.
Back to Top