#33288 closed Cleanup/optimization (fixed)
SQLite schema introspection should use PRAGMA instead of parsing to retrieve foreign keys
| Reported by: | Simon Charette | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The SQLite backend's DatabaseIntrospection.get_relations uses a complex combination of regexes to extract foreign key constraints from DDL while PRAGMA foreign_key_list works just fine as _get_foreign_key_constraints.
Change History (7)
comment:1 by , 4 years ago
| Has patch: | set |
|---|---|
| Version: | 3.2 → dev |
comment:2 by , 4 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 4 years ago
| Summary: | SQLite schema introspection layer should use PRAGMA instead of parsing to retrieve foreign keys → SQLite schema introspection should use PRAGMA instead of parsing to retrieve foreign keys |
|---|
comment:4 by , 4 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note:
See TracTickets
for help on using tickets.
PR