Opened 3 years ago
Closed 3 years ago
#33251 closed Cleanup/optimization (invalid)
RadioSelect HTML change is missing in Django 4.0 changelog.
| Reported by: | Dylan Verheul | Owned by: | nobody |
|---|---|---|---|
| Component: | Forms | Version: | 4.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
This commit b9e872b59329393f615c440c54f632a49ab05b78 changes the behavior of RadioSelect. It caused tests to fail in the django-bootstrap5 package when testing against Django main branch and Django 4.0.b1. The tests failed because a for=XXX was unexpectedly not generated in the label tag. I couldn't find the change in the changelog, but I could find the change in the source code (see commit link).
Change History (2)
comment:1 by , 3 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 3 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
| Summary: | Breaking change missing from Django 4.0 changelog → RadioSelect HTML change is missing in Django 4.0 changelog. |
| Type: | Uncategorized → Cleanup/optimization |
Note:
See TracTickets
for help on using tickets.
Thanks for this report, however b9e872b59329393f615c440c54f632a49ab05b78 was a bug fix and we don't add release notes for bug fixes.
Moreover the way how Django builds HTML is an implementation detail not something Django should guarantee and all bug fixes are backwards incompatible by nature.