Opened 17 years ago
Closed 17 years ago
#3320 closed (fixed)
[patch] update simplejson to the 1.5 version
| Reported by: | Owned by: | Jacob | |
|---|---|---|---|
| Component: | Core (Serialization) | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Bob Ippolito just released simplejson 1.5, here are the notes:
simplejson 1.5 is a major update that provides better Python 2.5 and Windows compatibility, and two new features that control encoding (indent for pretty-printing, and separators for generating optimally compact JSON).
This patch updates django.utils.simplejson from 1.3 to 1.5
Attachments (3)
Change History (12)
Changed 17 years ago by
| Attachment: | simplejson_1_5.diff added |
|---|
comment:1 follow-up: 2 Changed 17 years ago by
| Patch needs improvement: | set |
|---|---|
| Resolution: | → invalid |
| Status: | new → closed |
Changed 17 years ago by
| Attachment: | ticket-3320.diff added |
|---|
basically the same patches, but with full paths. Still doesn't work.
comment:2 Changed 17 years ago by
Replying to mir@noris.de:
If you run the testsuite, it produces lots of failures. I've used python 2.4. Can you please try to find out why and reopen? It's OK if you >can't find out and still want this in, please simply reopen with a comment, and I'll forward it then.
I found out, it was a problem with imports. Now the tests pass.
There's a kind of standard for patches, they better are created from the root of the sources, such that we don't have to figure out in which >directory the patch should be applied. I'm attaching your patches modified for this (but of course the testsuite still fails.)
Done thanks, the new patch should be perfect.
Changed 17 years ago by
| Attachment: | simplejson_1_5_new.diff added |
|---|
comment:3 Changed 17 years ago by
| Component: | Uncategorized → Serialization |
|---|---|
| Patch needs improvement: | unset |
| Triage Stage: | Unreviewed → Ready for checkin |
thanks, looks good now!
comment:6 Changed 17 years ago by
| Keywords: | reopen added |
|---|
comment:7 Changed 17 years ago by
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
comment:8 Changed 17 years ago by
| Keywords: | reopen removed |
|---|
If you run the testsuite, it produces lots of failures. I've used python 2.4. Can you please try to find out why and reopen? It's OK if you can't find out and still want this in, please simply reopen with a comment, and I'll forward it then.
There's a kind of standard for patches, they better are created from the root of the sources, such that we don't have to figure out in which directory the patch should be applied. I'm attaching your patches modified for this (but of course the testsuite still fails.)