Code

Opened 7 years ago

Closed 7 years ago

#3320 closed (fixed)

[patch] update simplejson to the 1.5 version

Reported by: LawrenceOluyede <l.oluyede@…> Owned by: jacob
Component: Core (Serialization) Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Bob Ippolito just released simplejson 1.5, here are the notes:


simplejson 1.5 is a major update that provides better Python 2.5 and Windows compatibility, and two new features that control encoding (indent for pretty-printing, and separators for generating optimally compact JSON).

This patch updates django.utils.simplejson from 1.3 to 1.5

Attachments (3)

simplejson_1_5.diff (12.4 KB) - added by LawrenceOluyede <l.oluyede@…> 7 years ago.
ticket-3320.diff (33.9 KB) - added by mir@… 7 years ago.
basically the same patches, but with full paths. Still doesn't work.
simplejson_1_5_new.diff (12.4 KB) - added by LawrenceOluyede <l.oluyede@…> 7 years ago.

Download all attachments as: .zip

Change History (12)

Changed 7 years ago by LawrenceOluyede <l.oluyede@…>

comment:1 follow-up: Changed 7 years ago by mir@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Resolution set to invalid
  • Status changed from new to closed

If you run the testsuite, it produces lots of failures. I've used python 2.4. Can you please try to find out why and reopen? It's OK if you can't find out and still want this in, please simply reopen with a comment, and I'll forward it then.

There's a kind of standard for patches, they better are created from the root of the sources, such that we don't have to figure out in which directory the patch should be applied. I'm attaching your patches modified for this (but of course the testsuite still fails.)

Changed 7 years ago by mir@…

basically the same patches, but with full paths. Still doesn't work.

comment:2 in reply to: ↑ 1 Changed 7 years ago by LawrenceOluyede <l.oluyede@…>

Replying to mir@noris.de:

If you run the testsuite, it produces lots of failures. I've used python 2.4. Can you please try to find out why and reopen? It's OK if you >can't find out and still want this in, please simply reopen with a comment, and I'll forward it then.

I found out, it was a problem with imports. Now the tests pass.

There's a kind of standard for patches, they better are created from the root of the sources, such that we don't have to figure out in which >directory the patch should be applied. I'm attaching your patches modified for this (but of course the testsuite still fails.)

Done thanks, the new patch should be perfect.

Changed 7 years ago by LawrenceOluyede <l.oluyede@…>

comment:3 Changed 7 years ago by mir@…

  • Component changed from Uncategorized to Serialization
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

thanks, looks good now!

comment:4 Changed 7 years ago by mir@…

oops -- where's the 'reopen' button?

comment:5 Changed 7 years ago by LawrenceOluyede <l.oluyede@…>

Test to see if I can reopen it

comment:6 Changed 7 years ago by Michael Radziej <mir@…>

  • Keywords reopen added

comment:7 Changed 7 years ago by adrian

  • Resolution invalid deleted
  • Status changed from closed to reopened

comment:8 Changed 7 years ago by Michael Radziej <mir@…>

  • Keywords reopen removed

comment:9 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in [4454].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.