Opened 2 years ago

Closed 2 years ago

#33054 closed New feature (fixed)

Make captureOnCommitCallbacks capture callbacks added by callbacks

Reported by: Evgenii Morozov Owned by: Evgenii Morozov
Component: Database layer (models, ORM) Version: 3.2
Severity: Normal Keywords: on_commit
Cc: Adam Johnson Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Evgenii Morozov)

Sometimes there's a need to add additional on_commit callback from on_commit callback. For example, on_commit callback saves some model, but post_save handler for that model also uses on_commit callback to perform some additional action (e.g. spawn celery task). Current Django TestCase code ignores new callbacks added during on_commit callback execution.

I present a simple solution for this problem:
​https://github.com/django/django/pull/14796

Change History (7)

comment:1 Changed 2 years ago by Mariusz Felisiak

Cc: Adam Johnson added
Triage Stage: Unreviewed → Accepted

Sounds reasonable. Thanks!

comment:2 Changed 2 years ago by Adam Johnson

Summary: Support post-commit hooks adding more post-commit hooks → Make captureOnCommitCallbacks capture callbacks added by callbacks

comment:3 Changed 2 years ago by Mariusz Felisiak

Owner: changed from nobody to Evgenii Morozov
Status: new → assigned

comment:4 Changed 2 years ago by Mariusz Felisiak

Needs documentation: set

comment:5 Changed 2 years ago by Mariusz Felisiak

Needs documentation: unset
Triage Stage: Accepted → Ready for checkin

comment:6 Changed 2 years ago by Evgenii Morozov

Description: modified (diff)

comment:7 Changed 2 years ago by Mariusz Felisiak <felisiak.mariusz@…>

Resolution: → fixed
Status: assigned → closed

In d89f976b:

Fixed #33054 -- Made TestCase.captureOnCommitCallbacks() capture callbacks recursively.

Note: See TracTickets for help on using tickets.
Back to Top