Opened 3 years ago

Closed 3 years ago

#33044 closed Bug (fixed)

pyproject.toml breaks pip install into user site directory with editable source

Reported by: Tim Graham Owned by: Carlton Gibson
Component: Packaging Version: dev
Severity: Release blocker Keywords:
Cc: Florian Apolloner, Chris Jerdonek, Nick Pope Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The addition of ​pyproject.toml in ​PR 13994 causes pip install -e into a user site directory to fail. See ​thread on the original PR.

Nick Pope ​proposes three possible options:

  1. The documentation approach -- using --no-build-isolation with pip install --editable --user will work.
  2. Add the following hack to setup.py in Django: 
    import site
import sys
site.ENABLE_USER_SITE = '--user' in sys.argv[1:]
  3. Revert the change that added build-system isolation until there is a blessed solution for editable installs with PEP 517.

Change History (3)

comment:1 by Mariusz Felisiak, 3 years ago

Cc: Florian Apolloner Chris Jerdonek Nick Pope added
Triage Stage: Unreviewed → Accepted

Agreed, we should do something. I'd prefer the second option.

comment:2 by Carlton Gibson, 3 years ago

Has patch: set
Owner: changed from nobody to Carlton Gibson
Status: new → assigned

​PR

comment:3 by GitHub <noreply@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In c1d50b90:

Fixed #33044 -- Reallowed editable install into user site directory.

Regression in f8f35e8c530aaf440fa8160327461460d79f6db2.

Note: See TracTickets for help on using tickets.
Back to Top