Code

Opened 7 years ago

Closed 7 years ago

#3303 closed defect (fixed)

[patch] Cleaning the newforms fields `clean` methods

Reported by: SmileyChris Owned by: adrian
Component: Forms Version:
Severity: normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Small patch to clean up some inconsistencies with the clean methods of fields in newforms.

(an outstanding inconsistency that I did not address in this patch is that sometimes super(fieldname, self).clean is used, other times Field.clean is used)

Attachments (1)

clean_clean.patch (2.2 KB) - added by SmileyChris 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by SmileyChris

comment:1 Changed 7 years ago by SmileyChris

  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [4367]) Fixed #3303 -- Cleaned some newforms clean() method implementations. Thanks for the patch, SmileyChris

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.