URLValidator test cases can be defined in a Python module

[Chris Jerdonek]

I noticed that the URLValidator tests have a number of test cases defined in separate text files (valid_urls.txt and invalid_urls.txt): ​https://github.com/django/django/tree/012f38f9594b35743e9ab231757b7b62db638323/tests/validators

However, it seems like it would be more maintainable if these test cases were defined in a Python module (e.g. the same tests.py file containing the test code). One reason is that there aren't actually that many test cases to warrant a separate file. Another is that having them as part of a Python module would permit them to be annotated with code comments. Currently, none of the test cases have any comments elaborating on what they're testing, and having them in a text file precludes that possibility. Finally, if there are any concerns about mistranscribing from the text files to a Python module, the transcription could be done with a Python script to eliminate the possibility of transcription errors.

[Mariusz Felisiak]

We could also keep them in .py modules, e.g. valid_urls.py, invalid_urls.py:

URLS = [
    ...
]

What do you think?

[Chris Jerdonek]

That's a good thought and would indeed be better. But since the two files are only 76 lines and 87 lines, I think we could safely keep them next to / nearer the actual tests. In Django's code, it's not uncommon to find single functions that run to that length (and whole modules a great deal longer than that), so I don't see much problem in having test data of that length. (If we needed to split anything, splitting the URLValidator tests off from DecimalValidator, email tests, etc. into its own test_urls.py might be a more natural division.)

[Mariusz Felisiak]

OK, let's move them directly to the TEST_DATA in tests/validators/tests.py.

[Bal Krishna Jha]

​https://github.com/django/django/pull/14705

[Mariusz Felisiak <felisiak.mariusz@…>]

In 03363628:

Fixed #32959 -- Moved tests URLs to validators.tests.