#32934 closed Bug (wontfix)
Fix Admin's sidebar height to be dynamic based on visible header
Reported by: | gary | Owned by: | Hrushikesh Vaidya |
---|---|---|---|
Component: | contrib.admin | Version: | 3.2 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | yes | UI/UX: | yes |
Description
The current sticky nav bar on admin anchors past the page. If you have long list of apps you have to scroll the whole page and then the nav to get to the bottom.
Images, context, and patch available at https://github.com/django/django/pull/14281
Change History (7)
comment:1 by , 3 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 3 years ago
Patch needs improvement: | set |
---|
Current approach on PR is overly complex. A simpler CSS-only approach should be feasible using a media query to handle different display sizes.
comment:3 by , 3 years ago
Easy pickings: | set |
---|---|
Owner: | removed |
Status: | assigned → new |
comment:5 by , 2 years ago
Patch needs improvement: | unset |
---|
comment:6 by , 2 years ago
Patch needs improvement: | set |
---|
comment:7 by , 2 years ago
Resolution: | → wontfix |
---|---|
Status: | assigned → closed |
Triage Stage: | Accepted → Unreviewed |
I'm going to resolve this as wontfix
.
The scrolling issue doesn't seem that bad: the left sidebar pauses independent scrolling at a point, scrolling in sync with the main section until reaching the bottom (of either) after that, so it's not 100% independent scrolling, but its OK. Perhaps it's Just what browsers do, and given #32204 we have the filter in-place now too, it's a minor glitch at worst.
In contrast the fixes are either too heavy (PR14281) or else have other display issues (PR15234) and so it's not clear there's a simple fix available (one that's really justified by the issue). Pending such actually showing up, I don't think further effort here is the best use of time.
Happy to reopen to consider patches.
Thanks -- accepting based on Tom's review of the PR.