Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#32934 closed Bug (wontfix)

Fix Admin's sidebar height to be dynamic based on visible header

Reported by: gary Owned by: Hrushikesh Vaidya
Component: contrib.admin Version: 3.2
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: yes

Description

The current sticky nav bar on admin anchors past the page. If you have long list of apps you have to scroll the whole page and then the nav to get to the bottom.

Images, context, and patch available at https://github.com/django/django/pull/14281

Change History (7)

comment:1 by Jacob Walls, 3 years ago

Owner: changed from nobody to gary
Status: newassigned
Triage Stage: UnreviewedAccepted

Thanks -- accepting based on Tom's review of the PR.

comment:2 by Carlton Gibson, 3 years ago

Patch needs improvement: set

Current approach on PR is overly complex. A simpler CSS-only approach should be feasible using a media query to handle different display sizes.

Last edited 3 years ago by Carlton Gibson (previous) (diff)

comment:3 by Carlton Gibson, 3 years ago

Easy pickings: set
Owner: gary removed
Status: assignednew

comment:4 by Hrushikesh Vaidya, 3 years ago

Owner: set to Hrushikesh Vaidya
Status: newassigned

A CSS only approach PR

comment:5 by Mariusz Felisiak, 2 years ago

Patch needs improvement: unset

comment:6 by Mariusz Felisiak, 2 years ago

Patch needs improvement: set

comment:7 by Carlton Gibson, 2 years ago

Resolution: wontfix
Status: assignedclosed
Triage Stage: AcceptedUnreviewed

I'm going to resolve this as wontfix.

The scrolling issue doesn't seem that bad: the left sidebar pauses independent scrolling at a point, scrolling in sync with the main section until reaching the bottom (of either) after that, so it's not 100% independent scrolling, but its OK. Perhaps it's Just what browsers do, and given #32204 we have the filter in-place now too, it's a minor glitch at worst.

In contrast the fixes are either too heavy (PR14281) or else have other display issues (PR15234) and so it's not clear there's a simple fix available (one that's really justified by the issue). Pending such actually showing up, I don't think further effort here is the best use of time.

Happy to reopen to consider patches.

Last edited 2 years ago by Carlton Gibson (previous) (diff)
Note: See TracTickets for help on using tickets.
Back to Top