Opened 3 years ago

Closed 3 years ago

#32910 closed Bug (fixed)

Different plural forms for some languages.

Reported by: Martin Svoboda Owned by: Mariusz Felisiak
Component: Internationalization Version: 2.2
Severity: Normal Keywords:
Cc: Claude Paroz Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Martin Svoboda)

#30439 has cause translations with different plural forms definitions are loaded in a separated catalogue.

Contrib apps Sites, Redirects and Sessions have different plural form definitions than other Slovak (SK) translations.

Change History (14)

comment:1 by Martin Svoboda, 3 years ago

Description: modified (diff)
Summary: Contrib apps: Different plural forms for Slovak → Contrib apps: Different plural forms for Slovak (SK)

comment:2 by Carlton Gibson, 3 years ago

Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

We backported #30439. We need to decide whether that's required here too (or if it's just a cleanup)

comment:3 by Mariusz Felisiak, 3 years ago

Cc: Claude Paroz added

comment:5 by Mariusz Felisiak, 3 years ago

Triage Stage: Accepted → Ready for checkin
Version: 3.2 → 2.2

I think we should update plural forms for all languages and backport this changes.

comment:6 by Mariusz Felisiak, 3 years ago

Owner: changed from nobody to Mariusz Felisiak
Status: new → assigned
Summary: Contrib apps: Different plural forms for Slovak (SK) → Different plural forms for some languages.

There are more affected languages I will fetch translations from Transifex and prepare PR.

comment:7 by Mariusz Felisiak, 3 years ago

Has patch: set
Type: Cleanup/optimization → Bug

​PR

comment:8 by Claude Paroz, 3 years ago

I don't think the backports are needed, isn't this only an optimization?

in reply to:  8 comment:9 by Mariusz Felisiak, 3 years ago

Replying to Claude Paroz:

I don't think the backports are needed, isn't this only an optimization?

I assumed that e3e48b00127c09eafe6439d980a82fc5c591b673 broke the previous behavior for users using multiple contrib apps, but I'm not an expert in this area.

comment:10 by Mariusz Felisiak, 3 years ago

Claude, if you think that backport is not necessary, I'd be more than happy to merge this to the main branch only.

comment:11 by Mariusz Felisiak, 3 years ago

Triage Stage: Ready for checkin → Accepted

comment:12 by Claude Paroz, 3 years ago

As I see it, the PR is improving things in that only one catalog is created for each language. But even in the current situation, I don't really see a bug (or the PR should demonstrate it with a regression test). See also that most or all affected catalogs don't contain any plural strings.

in reply to:  12 comment:13 by Mariusz Felisiak, 3 years ago

Replying to Claude Paroz:

As I see it, the PR is improving things in that only one catalog is created for each language. But even in the current situation, I don't really see a bug (or the PR should demonstrate it with a regression test). See also that most or all affected catalogs don't contain any plural strings.

Thanks for the clarification. I updated PR.

comment:14 by GitHub <noreply@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In a56531ab:

Fixed #32910 -- Unified different plural equations for the same language in contrib apps.

Thanks Martin Svoboda for the report and initial patch.

Note: See TracTickets for help on using tickets.
Back to Top