Migrations questioner uses bad grammar

[Christian Ullrich]

The interactive questioner, when it asks what to do about changes in nullability or adding a NOT NULL field, provides multiple options. Some of these speak to the user, some as the user.

One example of several:

You are trying to add a non-nullable field 'id' to mymodel without a default; we can't do that (the database needs something to populate existing rows).
Please select a fix:
 1) Provide a one-off default now (will be set on all existing rows with a null value for this column)
 2) Quit, and let me add a default in models.py

In option 1, Django offers the user the choice of entering the default value. Option 2 instead is the user telling Django what to do.

Each time I read this, I'm asking myself who the "me" in option 2 is. The most egregious case is in InteractiveMigrationQuestioner.ask_not_null_alteration(): "[...] let me handle existing rows [...] (e.g. because you added a RunPython [...]". In this sentence, "me" and "you" are the same.

Fix: Either reword the "provide" options to say "Let me enter a one-off default now", or the "let me" options to the same style as the "provide" options. I am very much in favor of the latter because I think this "me, the user" style is terrible.

[Jacob Walls]

Thanks, this has also occurred to me. For the example you quoted in full, perhaps: "Quit, so that a default in models.py can be added later." And something similarly passive for the other cases, avoiding the use of "you" entirely.

[Mateo Radman]

​PR is ready. Let me know if you have any suggestions regarding phrasing the questions.

[Tim Graham]

When adding a PR, the correct action is to check "Has patch" rather than close the ticket. See ​Triaging tickets and the "According to the ticket's flags, the next step(s) to move this issue forward are:" section of each open ticket.

[Mariusz Felisiak]

Muhammad, this ticket is already assigned to Mateo. Please try to find a ticket that is not assigned.

[Mateo Radman]

I think ​PR is ready to be merged. Thanks for everyone’s suggestions and involvement.

[Mariusz Felisiak <felisiak.mariusz@…>]

In d00fb4d2:

Refs #32900 -- Added test for ignoring the default value in InteractiveMigrationQuestioner.ask_not_null_alteration().

[Mariusz Felisiak <felisiak.mariusz@…>]

In 61c5eae:

Refs #32900 -- Added makemigrations tests for messages in interactive mode.

[Mariusz Felisiak <felisiak.mariusz@…>]

In 02bc7161:

Fixed #32900 -- Improved migrations questioner prompts.

[Mariusz Felisiak <felisiak.mariusz@…>]

In aa0d796e:

Refs #32900 -- Restored '[y/N]' in questioner prompt when merging migrations.

Regression in 02bc7161ec477afd4a7b328936eb8adac078d7b9.

[Mariusz Felisiak <felisiak.mariusz@…>]

In 1aada25e:

[4.0.x] Refs #32900 -- Restored '[y/N]' in questioner prompt when merging migrations.

Regression in 02bc7161ec477afd4a7b328936eb8adac078d7b9.

Backport of aa0d796e37c4b8056148de2f68726aae9d20399c from main