Opened 3 years ago
Closed 3 years ago
#32884 closed Cleanup/optimization (fixed)
Login header title is slightly off-center
| Reported by: | Lou Huang | Owned by: | Lou Huang |
|---|---|---|---|
| Component: | contrib.admin | Version: | 3.2 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | yes |
Description
On the /admin/login page, and on window sizes greater than 1024px wide, the header that says "Django administration" is very slightly off-center. This is caused by a 20px right margin on the #branding h1 selector (provided in base.css). See screenshots.
I don't think the solution is as simple as removing the margin, since the style is used on other administration pages, but perhaps an override is necessary (e.g. removing the right margin on the .login #header h1 selector, which is already declared).
I'm happy to provide a PR for review if needed. Thanks!
Attachments (2)
Change History (6)
by , 3 years ago
| Attachment: | Screen Shot 2021-06-26 at 4.43.17 PM.png added |
|---|
by , 3 years ago
| Attachment: | Screen Shot 2021-06-26 at 4.49.52 PM.png added |
|---|
comment:1 by , 3 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
| Triage Stage: | Unreviewed → Accepted |
| Type: | Bug → Cleanup/optimization |
comment:2 by , 3 years ago
| Has patch: | set |
|---|
Pull request created: https://github.com/django/django/pull/14567
comment:3 by , 3 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note:
See TracTickets
for help on using tickets.
Thanks for the report. Agreed, we can clear the margin on
.login #header h1.Would be great, thanks.