Opened 3 years ago

Closed 2 years ago

Last modified 13 months ago

#32873 closed Cleanup/optimization (fixed)

Deprecate USE_L10N setting.

Reported by: Carlton Gibson Owned by: Claude Paroz
Component: Internationalization Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There's a proposal from Claude to remove the USE_L10N setting.

My motivations are:

  • one less setting
  • simplication of the code and logic regarding USE_18N/USE_L10N/USE_TZ

settings

  • a user-friendly default behavior

Accepting on the basis of the discussion there.

Change History (12)

comment:1 by Claude Paroz, 2 years ago

Patch needs improvement: unset

Should be ready for review.

comment:2 by GitHub <noreply@…>, 2 years ago

In 4a43335d:

Fixed #30086, Refs #32873 -- Made floatformat template filter independent of USE_L10N.

comment:3 by Mariusz Felisiak, 2 years ago

Summary: Remove USE_L10N settingDeprecate USE_L10N setting.

Claude's PR should be used when USE_L10N will be removed in Django 5.0.

comment:4 by Mariusz Felisiak, 2 years ago

comment:5 by Mariusz Felisiak, 2 years ago

Triage Stage: AcceptedReady for checkin

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

Resolution: fixed
Status: assignedclosed

In 676bd08:

Fixed #32873 -- Deprecated settings.USE_L10N.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@…>

comment:7 by Claude Paroz, 2 years ago

Mariusz, I still rebased my original patch, as it may be of some help at the time of the deprecation removal. I know code might move a lot until then, but still in the case it might be useful, I'm keeping that branch on my fork: https://github.com/claudep/django/tree/remove_use_l10n

in reply to:  7 comment:8 by Mariusz Felisiak, 2 years ago

Replying to Claude Paroz:

Mariusz, I still rebased my original patch, as it may be of some help at the time of the deprecation removal. I know code might move a lot until then, but still in the case it might be useful, I'm keeping that branch on my fork: https://github.com/claudep/django/tree/remove_use_l10n

Many thanks!

comment:9 by GitHub <noreply@…>, 2 years ago

In 7fd2deb:

Refs #32873 -- Avoided looking up settings._USE_L10N_INTERNAL twice.

comment:10 by Carlton Gibson <carlton.gibson@…>, 15 months ago

In 9582f2f9:

Refs #32873 -- Adjusted formatting note on USE_L10N default.

comment:11 by Carlton Gibson <carlton.gibson@…>, 15 months ago

In 3a46d5ec:

[4.1.x] Refs #32873 -- Adjusted formatting note on USE_L10N default.

Backport of 9582f2f9d173935fef35c8c27b0f80258b1fb106 from main

comment:12 by Mariusz Felisiak <felisiak.mariusz@…>, 13 months ago

In 8d98f99a:

Refs #32873 -- Removed settings.USE_L10N per deprecation timeline.

Note: See TracTickets for help on using tickets.
Back to Top