Sitemap.items() gets called several times: Fix or document?

[Thomas Güttler]

The ​Sitemap.items() method might get called several times (if you generate several pages in batch)

This is confusing and might waste computation resources.

    def _urls(self, page, protocol, domain):
        urls = []
        latest_lastmod = None
        all_items_lastmod = True  # track if all items have a lastmod
        paginator_page = self.paginator.page(page)
        for item in paginator_page.object_list:
            loc = f'{protocol}://{domain}{self._location(item)}'
            ....

    @property
    def paginator(self):
        return paginator.Paginator(self._items(), self.limit)

I see two options now:

Option1: Document this behaviour.

Option2: make paginator a cached_property.

[Carlton Gibson]

Hi Thomas, thanks.

The ​Sitemap.items() method might get called several times (if you generate several pages in batch)

I don't see this as any different from (e.g.) a paginated ListView, i.e. not really as problematic.

If you wanted to add paginator to the reference docs though, with a comment such as You may wish to override as a cached property this if you are generating multiple sitemap pages in a batch (or something) I guess that wouldn't hurt.

[Mariusz Felisiak]

​PR

[Mariusz Felisiak <felisiak.mariusz@…>]

In 775f7506:

Fixed #32850 -- Doc'd Sitemap.paginator.

[Mariusz Felisiak <felisiak.mariusz@…>]

In aaef4111:

[3.2.x] Fixed #32850 -- Doc'd Sitemap.paginator.

Backport of 775f7506d7fbabf79d8bdec4ccf039ce2870fe70 from main