Opened 17 years ago
Closed 14 years ago
#3274 closed enhancement (fixed)
[patch] Provide date_list to template context in archive_month view
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | Generic views | Version: | dev |
| Severity: | normal | Keywords: | archive_month date_list |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
As django.views.generic.date_based.archive_index (and django.views.generic.date_based.archive_year provide) provide a list of datetime.date to template context representing all years (and months) that have objects available according to queryset, it would be coerent that django.views.generic.date_based.archive_month provides a date_list containing datetime.date representing all days that have objects available according to queryset.
Attachments (2)
Change History (8)
by , 17 years ago
| Attachment: | date_list_for_archive_month.diff added |
|---|
comment:2 by , 17 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
comment:3 by , 17 years ago
| Needs tests: | set |
|---|---|
| Triage Stage: | Ready for checkin → Accepted |
follow-up: 5 comment:4 by , 16 years ago
this works, and has zero potential of breaking anything. in the name of consistency, someone please commit this.
comment:5 by , 15 years ago
Replying to propanbutan <propanbutan@gmx.net>:
this works, and has zero potential of breaking anything. in the name of consistency, someone please commit this.
It needs a test. tests/regressiontests/views/tests/generic/date_based.py looks like a likely a good place to add one.
by , 14 years ago
| Attachment: | month_archive_date_list.diff added |
|---|
comment:6 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
In r12195, forgetting to put the correct incantation in the commit message:
Fixed: 3274: Added date_list context variable to the archive_month generic view, consistent with archive_index and archive_year. Thanks Sean Brant
date_list_for_archive_month