Examples in django.utils.baseconv.BaseConverter's docstring are incorrect.

[pythonwood]

---

NOW:
In fact, I found the right way is patch doc string instead of code.

I have a simple right (new) pull in gihub 14344 ​https://github.com/django/django/pull/14344

---

BEFORE:

I have a simple pull in gihub # 14339
​https://github.com/django/django/pull/14339/commits/86e0ec9df0b5ed7a9160c10974bf1adef19eb539

def encode(self, i):
      neg, value = self.convert(i, self.decimal_digits, self.digits, '-')

try and know that arg '-' should be self.sign:

In [1]: from django.utils import baseconv

In [2]: base11 = baseconv.BaseConverter('0123456789-', sign='$')

In [3]: base11.encode('$1234')

ValueError: substring not found

[Mariusz Felisiak]

Thanks for the report. I also agree with Simon that we should deprecate the django.utils.baseconv module, but this can be done separately, see #32712.

[pythonwood]

​PR

[pythonwood]

in fact, after look into regression test tests/utils_tests/test_baseconv.py, I fount that It is wrong doc string instead of code.

[GitHub <noreply@…>]

In 071cf686:

Fixed #32709 -- Corrected examples in django/utils/baseconv.py docstring.