Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#32687 closed Bug (fixed)

database client runshell doesn't respect os.environ values in some cases

Reported by: Konstantin Alekseev Owned by: Konstantin Alekseev
Component: Core (Management commands) Version: 3.2
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Konstantin Alekseev)

postgresql client returns empty dict instead of None for env
as a result os.environ is not used and empty env passed
to subprocess.
Bug introduced in https://github.com/django/django/commit/bbe6fbb8768e8fb1aecb96d51c049d7ceaf802d3#diff-e98866ed4d445fbc94bb60bedffd5d8cf07af55dca6e8ffa4945931486efc3eeR23-R26
PR https://github.com/django/django/pull/14315

Change History (7)

comment:1 Changed 8 months ago by Konstantin Alekseev

Description: modified (diff)

comment:2 Changed 8 months ago by Nick Pope

Easy pickings: set
Needs tests: set
Severity: NormalRelease blocker
Triage Stage: UnreviewedSomeday/Maybe

Agreed, this is a regression in bbe6fbb8768e8fb1aecb96d51c049d7ceaf802d3.

Please can you add a test and a release note for 3.2.1?

PR

comment:3 Changed 8 months ago by Nick Pope

Triage Stage: Someday/MaybeAccepted

(Oops, my mistake.)

comment:4 Changed 8 months ago by Nick Pope

Needs tests: unset
Patch needs improvement: set

comment:5 Changed 8 months ago by Mariusz Felisiak

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:6 Changed 8 months ago by Mariusz Felisiak <felisiak.mariusz@…>

Resolution: fixed
Status: assignedclosed

In 6e742dab:

Fixed #32687 -- Restored passing process’ environment to underlying tool in dbshell on PostgreSQL.

Regression in bbe6fbb8768e8fb1aecb96d51c049d7ceaf802d3.

comment:7 Changed 8 months ago by Mariusz Felisiak <felisiak.mariusz@…>

In 55cb3c8a:

[3.2.x] Fixed #32687 -- Restored passing process’ environment to underlying tool in dbshell on PostgreSQL.

Regression in bbe6fbb8768e8fb1aecb96d51c049d7ceaf802d3.

Backport of 6e742dabc95b00ba896434293556adeb4dbaee8a from main.

Note: See TracTickets for help on using tickets.
Back to Top