#32687 closed Bug (fixed)
database client runshell doesn't respect os.environ values in some cases
Reported by: | Konstantin Alekseev | Owned by: | Konstantin Alekseev |
---|---|---|---|
Component: | Core (Management commands) | Version: | 3.2 |
Severity: | Release blocker | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
postgresql client returns empty dict instead of None for env
as a result os.environ is not used and empty env passed
to subprocess.
Bug introduced in https://github.com/django/django/commit/bbe6fbb8768e8fb1aecb96d51c049d7ceaf802d3#diff-e98866ed4d445fbc94bb60bedffd5d8cf07af55dca6e8ffa4945931486efc3eeR23-R26
PR https://github.com/django/django/pull/14315
Change History (7)
comment:1 by , 3 years ago
Description: | modified (diff) |
---|
comment:2 by , 3 years ago
Easy pickings: | set |
---|---|
Needs tests: | set |
Severity: | Normal → Release blocker |
Triage Stage: | Unreviewed → Someday/Maybe |
comment:4 by , 3 years ago
Needs tests: | unset |
---|---|
Patch needs improvement: | set |
comment:5 by , 3 years ago
Patch needs improvement: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
Agreed, this is a regression in bbe6fbb8768e8fb1aecb96d51c049d7ceaf802d3.
Please can you add a test and a release note for 3.2.1?
PR