Opened 6 years ago

Closed 4 years ago

#32603 closed New feature (fixed)

Add transaction handling to Changelist list_editable processing.

Reported by: Vlastimil Zíma Owned by: Shubh Parmar
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

It seems that changelist_view in Django admin is missing a transaction. Since the view may change data in database, it should be wrapped in a transaction to prevent unexpected states in case of errors.

Change History (8)

comment:1 by Carlton Gibson, 6 years ago

Summary: Changelist view in admin is missing transaction → Add transaction handling to Changelist list_editable processing.
Triage Stage: Unreviewed → Accepted
Type: Bug → New feature

So, this has never been wrapped in a transaction.
See ​https://github.com/django/django/commit/7bc0878922 where it was added.

Happy to accept as a New Feature to investigate adding that. (I can't immediately see any obvious blockers.)

comment:2 by Shubh Parmar, 4 years ago

Owner: changed from nobody to Shubh Parmar
Status: new → assigned

comment:3 by Jacob Walls, 4 years ago

Has patch: set

​PR

comment:4 by Mariusz Felisiak, 4 years ago

Needs tests: set

comment:5 by Shubh Parmar, 4 years ago

Needs tests: unset

comment:6 by Mariusz Felisiak, 4 years ago

Patch needs improvement: set

comment:7 by Mariusz Felisiak, 4 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 7a39a691:

Fixed #32603 -- Made ModelAdmin.list_editable use transactions.

Note: See TracTickets for help on using tickets.
Back to Top