Opened 18 years ago
Closed 18 years ago
#3258 closed enhancement (fixed)
[patch] Make newforms.models.save_instance work with a subset of model fields
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | Forms | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | alex@… | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The save_instance() function in newforms.models expects clean_data to have a key/value pair for every field in the model. This needlessly limits one from using a form to update only part of a model.
The attached patch adds a check that the field name is in the clean_data dict before modifying an instance's value for that field.
Attachments (3)
Change History (9)
by , 18 years ago
| Attachment: | savesubset.diff added |
|---|
comment:1 by , 18 years ago
| Needs documentation: | set |
|---|---|
| Needs tests: | set |
| Triage Stage: | Unreviewed → Accepted |
Thanks, Andrew. I'm not sure, but I *think* that a sentence should be added in the docs about this.
comment:2 by , 18 years ago
This is much better than the current behaviour. save_instance shouldn't require all of the fields in the form.
comment:3 by , 18 years ago
| Needs documentation: | unset |
|---|
save_instance isn't documented anyway, so this ticket doesn't specifically need documentation yet.
by , 18 years ago
| Attachment: | save_instance.patch added |
|---|
by , 18 years ago
| Attachment: | save_instance.2.patch added |
|---|
comment:4 by , 18 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
I'm not sure that this specific ticket needs tests either since there are no existing tests for save_instance. I'm going to promote to checkin for Adrian to have a look at anyway.
comment:5 by , 18 years ago
| Cc: | added |
|---|
comment:6 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
patch