RequestSite and IDN

[François Poulain]

Without using django.contrib.sites, get_current_site reply a RequestSite instance defining name and domain.

On a IDN setup, we are currently getting Punicode in the name due to the init sequence:

      def __init__(self, request):                                                
          self.domain = self.name = request.get_host() 

IMHO a punicode version of the domain in not what I expect in the name attribute.

I suggest that if any part of the domains starts with xn-- it should be tried to set the name by decoding the domain from idna.

How do you think about it? (I may provide patch if you agree on the behavior)

[Mariusz Felisiak]

This is a ​documented behavior:

"Sets the name and domain attributes to the value of get_host()."

and ​get_host() "returns the originating host of the request using information from the ..."

Decoding punycodes would be backward incompatible and it's not clear to me why a puncode in name is an issue.

[François Poulain]

This is a ​documented behavior

Ok, thanks for the link.

it's not clear to me why a puncode in name is an issue

I thought it because the ​models.Site documentation states that name is "A human-readable “verbose” name for the website."