Disable field creation in forms for hidden model fields

[mssnlayam@…]

django.newforms.models.form_for_model() should not create a form field for model fields declared with editable=False .

[mssnlayam@…]

Patch from the root directory of django distribution, please ignore the previous patch.

[Adrian Holovaty]

I'm not sure whether this should be the correct behavior. Is editable=False intended to be only for the admin site, or does it mean that field shouldn't be edited by *any* form?

[Adrian Holovaty]

I'm putting [design-q] in the subject to designate "a design decision needs to be made here." It's just as a little experiment to see whether this extra tagging is useful.

[Adrian Holovaty]

Changed summary to put [design-q] first, to be consistent.

[Philipp Keller <philipp.keller@…>]

I've read the following
​http://www.b-list.org/weblog/2006/11/02/django-tips-auto-populated-fields:

The created and updated fields now have editable=False. This means that they will never show up in an automatic manipulator or in the admin. They’re still required, they just won’t be displayed anywhere. 

So I supposed this behaviour is meant for newforms too and just never got implemented.

But for the discussion: shouldn't be the other way round? I'd expect a editable=false field not to appear in a automatic generated form. I'd expect the form field list for admin in a configuration in the admin subclass.

[Simon G. <dev@…>]

Discussion here: ​http://groups.google.com/group/django-developers/browse_thread/thread/50150b61aca46a7e

[Philipp Keller <philipp.keller@…>]

Since the discussion didn't bring up any objections against this solution, I switch triage to "accepted"

[Michael Radziej <mir@…>]

Hi Philip, you're welcome to help out and triage tickets! But, please, go through everything as described in ​triage docs.

The patch in this ticket does not apply anymore (so I can't test it). Can you please update it? Tests and docs will be needed before it can be checked id, too.

[Philipp Keller <philipp.keller@…>]

Patch matching 4451, included patch as well

[Philipp Keller <philipp.keller@…>]

Hi Michael, sorry, I forgot to add needs_docs and needs_tests to this ticket.
I did a new patch that matches the current trunk. I've also included a test in model_forms/models.py
It's quite hard to add documentation since the whole models.py isn't documented yet. Some time ago I wrote a tutorial on my blog (​http://code.pui.ch/2007/01/07/using-djangos-newforms/) that could serve as a start point for adding documentation for the form_for_model and form_for_instance functions.
What do you think?

[mir@…]

Thanks for the tests. The assigned field is to match tickets to core developers, please leave it as it is unless you know exactly what you're doing ;-)

[christian@…]

I have tested the patch (disable_formfield_for_hidden_fields_trunk.diff), and it seems to work fine.

[Adrian Holovaty]

(In [4548]) Fixed #3247 -- newforms form_for_model() and form_for_instance() no longer create form fields for database fields with editable=False. Thanks for the patch, mssnlayam@… and Philipp Keller