Opened 4 years ago
Last modified 4 years ago
#32383 closed New feature
ManifestStaticFilesStorage doesn't update JavaScript source map references — at Version 4
Reported by: | Adam Johnson | Owned by: | Adam Johnson |
---|---|---|---|
Component: | contrib.staticfiles | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
ManifestStaticFilesStorage replaces URL's in CSS files with the hashed equivalents, but doesn't have any other out-of-the-box rules. One common use case for cross-static-file-references is a JavaScript source map, a structured comment in a JS file.
I think it would be a reasonable inclusion that Django modifies these too. I got it working (with Whitenoise's subclass of ManifestStaticFilesStorage
) with this extra regex pattern:
from whitenoise.storage import CompressedManifestStaticFilesStorage class SuperStaticFilesStorage(CompressedManifestStaticFilesStorage): patterns = CompressedManifestStaticFilesStorage.patterns + ( ( "*.js", ( ( r"(//# sourceMappingURL=(.*?\.js\.map))$", "//# sourceMappingURL=%s", ), ), ), )
Ideally the regex would start with a ^
, which requires the regex mulitline flag, and would NOT be compiled in case-insenstive mode. The current storage implementation forces compiling regexes with only the case insensitive flag.
Change History (4)
comment:1 by , 4 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 4 years ago
Owner: | removed |
---|---|
Status: | assigned → new |
comment:3 by , 4 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:4 by , 4 years ago
Description: | modified (diff) |
---|---|
Owner: | set to |
Status: | new → assigned |
Yep. If we can do this then super 👍