Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#32374 closed Bug (fixed)

Migrations are marked applied even if deferred SQL fails to execute

Reported by: Simon Charette Owned by: Simon Charette
Component: Migrations Version: 2.2
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The changes introduced in c86a3d80a25acd1887319198ca21a84c451014ad to address #29721 fail to account for the possibility of the schema editor accumulation of deferred SQL which is run at SchemaEditor.__exit__ time.

Change History (4)

comment:1 by Simon Charette, 4 years ago

Has patch: set

comment:2 by Mariusz Felisiak, 4 years ago

Owner: changed from nobody to Simon Charette
Triage Stage: Unreviewed → Accepted

comment:3 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 0c42cdf0:

Fixed #32374 -- Stopped recording migration application before deferred SQL.

Migrations cannot be recorded in the same transaction as its associated
DDL operations when some of it is deferred until the schema editor
context exits.

Regression in c86a3d80a25acd1887319198ca21a84c451014ad.

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In 6520ce5:

[3.2.x] Fixed #32374 -- Stopped recording migration application before deferred SQL.

Migrations cannot be recorded in the same transaction as its associated
DDL operations when some of it is deferred until the schema editor
context exits.

Regression in c86a3d80a25acd1887319198ca21a84c451014ad.

Backport of 0c42cdf0d2422f4c080e93594d5d15381d6e955e from master

Note: See TracTickets for help on using tickets.
Back to Top